Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command 'cmake ..; make -j' returned non-zero exit status 1. #3

Open
roy86 opened this issue Feb 23, 2024 · 9 comments · May be fixed by #5
Open

Command 'cmake ..; make -j' returned non-zero exit status 1. #3

roy86 opened this issue Feb 23, 2024 · 9 comments · May be fixed by #5

Comments

@roy86
Copy link

roy86 commented Feb 23, 2024

I have attempted to install and whilst i've been able to solve for the Cmake not found issues, I cannot work out what this error is being triggered by while attempting to install using PIP.

subprocess.CalledProcessError: Command 'cmake ..; make -j' returned non-zero exit status 1.

System: Win11 using Git Bash

$ cmake --version cmake version 3.29.0-rc2
$ make --version GNU Make 4.4.1
$ python --version Python 3.12.1
$ pip -V pip 24.0

@mengqiDK
Copy link

subprocess.CalledProcessError: Command 'cmake ..; make -j' returned non-zero exit status 1.

I also encountered the same problem, how did you solve it? Is it not supported by windows?

@roy86
Copy link
Author

roy86 commented May 30, 2024

@mengqiDK Not solved. Following the setup process still fails on Windows.

@mhandb
Copy link

mhandb commented Jun 11, 2024

@roy86 I have opened a PR for windows support: #5

You can try to install the branch waiting for it to be merged:
pip install https://github.com/mhandb/egl_probe/archive/fix_windows_build.zip

@roy86
Copy link
Author

roy86 commented Jun 13, 2024

@roy86 I have opened a PR for windows support: #5

You can try to install the branch waiting for it to be merged: pip install https://github.com/mhandb/egl_probe/archive/fix_windows_build.zip

sure thing, i'll give it a test

@csufangyu
Copy link

csufangyu commented Jun 26, 2024

hello, I get the same problem, but when I try to build from source(branch is fix_windows_build), when I run "make -j" , get the error:
error: invalid conversion from 'PFNEGLGETPROCADDRESSPROC {aka void (* (attribute((stdcall)) )(const char))()}' to 'GLADloadfunc {aka void (* ()(const char))()}' [-fpermissive]
can you hlep me?

@mhandb
Copy link

mhandb commented Jun 26, 2024

@csufangyu you are probably trying to build for x86, and it raised another issue as the current glad source code which does not handle properly the different convention call "stdcall vs cdecl (default in x86)".
Do you want to target x86 (32bit) architecture?

Did you try to install it from source using this command bellow?
pip install https://github.com/mhandb/egl_probe/archive/fix_windows_build.zip

@zhiyuandaily
Copy link

zhiyuandaily commented Jun 28, 2024

@mhandb I have tried to try to install it from the source using this command, but I still failed and got the same error:
" Command 'cmake ..; make -j' returned non-zero exit status 1." Could you solve it?

@mhandb
Copy link

mhandb commented Jun 28, 2024

@mhandb I have tried to try to install it from the source using this command, but I still failed and got the same error: " Command 'cmake ..; make -j' returned non-zero exit status 1." Could you solve it?

This is interesting as I removed this command line cmake ..; make -j from setup.py in the fix_windows_build branche and replaced it with

        subprocess.check_call("cmake -S .. -B .", cwd=build_dir, shell=True)
        subprocess.check_call("cmake --build .", cwd=build_dir, shell=True)

Then I do not understand the error you have saying that cmake ..; make -j fails.

Maybe some cache issue?

@zhiyuandaily
Copy link

@mhandb thank you!!! I cleaned the cache and It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants