Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error instead of warning when an incorrect tag entry is present #1600

Open
Ellivers opened this issue Sep 17, 2024 · 3 comments
Open

Show error instead of warning when an incorrect tag entry is present #1600

Ellivers opened this issue Sep 17, 2024 · 3 comments

Comments

@Ellivers
Copy link

Currently, Spyglass shows a warning for nonexistent entries in tags, despite Minecraft showing an error for it and failing to load the tag.

image
image

This applies to all tags, not just function tags.

@misode
Copy link
Member

misode commented Sep 17, 2024

I don't think we're going to change this. The undeclaredSymbol linting rule is a warning by default, mostly because it is not a syntax error and because there are some occations where this is not a problem (using a #c:something tag, referencing symbols from a dependency, other pack, or mod)

@Ellivers
Copy link
Author

In this case, it's pretty much a syntax error. Would it be possible to handle tags differently compared to other places where undeclaredSymbol is used?

@misode
Copy link
Member

misode commented Sep 30, 2024

@Ellivers I don't immediately see why tags should be handled differently. It is possible to manually configure this linting check to emit an error, see https://spyglassmc.com/user/lint/undeclaredSymbol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants