Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated deprecation message #1384

Open
clemenshelm opened this issue Oct 3, 2024 · 1 comment
Open

Outdated deprecation message #1384

clemenshelm opened this issue Oct 3, 2024 · 1 comment

Comments

@clemenshelm
Copy link

clemenshelm commented Oct 3, 2024

I'm using the draper gem in my application which stores decorators in app/decorators. Now spina gave me the warning:

using app/decorators is deprecated in favor of app/overrides. Read more about overriding Spina at spinacms.com/guides

I'm not overriding spina decorators, so the message is misleading anyway.

However, when I tried to upgrade to Rails 7.2 today, this became a blocker because apparently ActiveSupport::Deprecation.warn isn't available anymore.

NoMethodError: private method `warn' called for ActiveSupport::Deprecation:Class (NoMethodError)

          ActiveSupport::Deprecation.warn("using app/decorators is deprecated in favor of app/overrides. Read more about overriding Spina at spinacms.com/guides")

What would be the best solution here? Could you just remove the warning?

@Bramjetten
Copy link
Contributor

Let's just remove the deprecation warning altogether 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants