Removing a file

[Code-Grump]

I'm trying to write a test suite (for the change to code generation SpecFlowOSS/SpecFlow#1362), but can't currently create a test for removing a feature file and performing a build, because there's no mechanism for "updating" a generated project.

Is it reasonable to introduce a RemoveFile method to the Project and ProjectDriver classes? I'm not clear how that might reconcile with the SolutionWriter being a one-time process with no room for removing content.

[SabotageAndi]

I wouldn't put the method on these two classes, because as you wrote that they are for the one-time process to create the project.
Put it into a class of it's own. For sdk-style projects removing the file is enough. Only for the old-csproj style you have to adjust the file itself.

[Code-Grump]

In that case would it be better to keep that code out of the test project generator for the time being? It's only useful in exactly one test at this time and I'm happy to keep things simple.

…

On Thu, 1 Aug 2019, 07:24 Andreas Willich, ***@***.***> wrote: I wouldn't put the method on these two classes, because as you wrote that they are for the one-time process to create the project. Put it into a class of it's own. For sdk-style projects removing the file is enough. Only for the old-csproj style you have to adjust the file itself. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAY5LSQAKT5FAZERR3IHBU3QCJ6RLANCNFSM4IIK2CDQ> .