Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup: fixes and doc improvements #570

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Backup: fixes and doc improvements #570

wants to merge 7 commits into from

Conversation

ukkopahis
Copy link

@ukkopahis ukkopahis commented Jun 5, 2022 •
edited
Loading

untested - don't merge

Improvements:

  • backup & restore documentation: Fix the "coming soon" placeholders. Include all useful stuff from docs/Backups.md.old.
  • refactor: simplify by inlining the small scripts from scripts/backup_restore (each of them is invoked only from a single place)

Fixes:

  • only stop/start the stack for backup, don't down/up it (which recreates containers into a different state if docker-compose.yml was edited or new images were pulled)
  • chown files using the correct group
  • work regardless of the current directory when script is executed
  • automatically re-invoke script using sudo: a) to ensure no backup permission problems accessing files and b) restore is done using the correct file owners and permissions.
  • chown all of ./backup to the appropriate non-root user

Closes #566, Fixes #439, Fixes #293, Fixes #254, Fixes #352

@ukkopahis
backup: only stop the stack for backup
198f878 
Using docker-compose down/up will recreate the containers,
possibly using different images if a manual "docker-compose pull"
had been executed.
@ukkopahis
backup: refactor: inline for clarity
de2c030
@ukkopahis
backup: fix to chown to correct group
5badc2f 
Previous version only worked for "pi:pi" or similar, where
user and group names are the same.
@ukkopahis
backup: improve reliability and documentation
7de8016 
* allow starting backup from any folder
* automatically run using sudo
  (to never fail due to ./backup owned by root)
* run post_backup.sh after 'docker-compose start', to minimize downtime
  when e.g. uploading backups to a remote server
* chown all of ./backup to the appropriate user

Fixes SensorsIot#566
@ukkopahis
restore.sh: refactor: cleanup & simplify
89d7cf0
@ukkopahis
restore.sh: ensure run as root
eb1dcbe 
* allow start from any current folder
* chmod logfile to allow all to read it
@ukkopahis
backup: include .env and docker-compose.override.yml
922464c
@ukkopahis ukkopahis mentioned this pull request Jun 24, 2022
Closed
@tomandegg tomandegg mentioned this pull request Apr 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Don't merge yet
Projects
None yet
Milestone
No milestone
2 participants
@ukkopahis @Slyke