Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement skeleton prop injection through OnyxPageLayout and OnyxForm #1955

Open
10 tasks
MajaZarkova opened this issue Oct 14, 2024 · 0 comments
Open
10 tasks
Assignees

Comments

@MajaZarkova
Copy link
Contributor

MajaZarkova commented Oct 14, 2024

Why?

From @jannick-ux:

Skeleton modes are used for the initial loading of the entire page. So when I am directed to a page, the skeleton mode of the components is shown until the components themselves or the entire page is loaded.
Loading mode, on the other hand, is used when the components themselves no longer need to be loaded, but the data is processed or validated via a button click, for example (classic example “processing”).

To make this easier for the user and reflect this global/page state, we should enable the user to trigger the skeleton mode via an injection. the injection is already implemented. OnyxPageLyout and OnyxForm are providing this property. The issue arises when we have OnyxForm nested inside an OnyxPageLayout. For example if we set the skeleton prop to true on OnyxPageLayout layer, it doesn't reach the components inside the OnyxForm.

Acceptance criteria

  • components inside an OnyxForm can inject (have access to) the skeleton prop on OnyxPageLayout layer, only if it's not set on OnyxForm layer.
  • skeleton prop on OnyxForm layer tакеs advantage before the skeleton prop on OnyxPageLayout layer.
  • A description for the prop is added and shown in stroybook

Implementation details

see

Definition of Done

  • covered by component tests
  • screenshot tests are updated
  • follow-up tickets were created if necessary
  • updated version + documentation is deployed
  • Storybook can show the feature
  • Storybook code snippet of new/changed examples are checked that they are generated correctly

Approval

  • Storybook
  • Deployed Docs
  • approved by dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant