Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompat with Immersive Portals #29

Open
andi-makes opened this issue Jul 1, 2023 · 3 comments · May be fixed by #44
Open

Incompat with Immersive Portals #29

andi-makes opened this issue Jul 1, 2023 · 3 comments · May be fixed by #44
Labels
bug Something isn't working help wanted Extra attention is needed reproduced

Comments

@andi-makes
Copy link
Contributor

Lighty doesn't seem to get notified about light updates when immersive portals is installed

@andi-makes andi-makes added bug Something isn't working reproduced labels Jul 1, 2023
@andi-makes
Copy link
Contributor Author

note for future self: Move mixin at the beginning and see if that fixes it

https://github.com/SchmarrnDevs/Lighty/blob/1.20.1/common/src/main/java/dev/schmarrn/lighty/mixin/LightUpdateMixin.java#L28

@andi-makes andi-makes added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 1, 2023
@andi-makes
Copy link
Contributor Author

With commit 3b6b403, the issue gets reduced a little bit, any block update triggers a recomputation of that subchunk, but only that subchunk. So if you place a torch at the border of a chunk, no neighboring chunks get updated.

Didn't investigate the mixin location.

@andi-makes
Copy link
Contributor Author

Conditionally mixin into https://github.com/iPortalTeam/ImmersivePortalsMod/blob/1.20.1/imm_ptl_core/src/main/java/qouteall/imm_ptl/core/chunk_loading/ImmPtlClientChunkMap.java#L233 if Immersive Portals is loaded, this should fix the issue completely

@andi-makes andi-makes linked a pull request Aug 23, 2023 that will close this issue
@andi-makes andi-makes removed the good first issue Good for newcomers label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant