From 5f832920fce06531b36daf551ae62c1d70e767b7 Mon Sep 17 00:00:00 2001
From: andi-makes <andi@andi-makes.dev>
Date: Sun, 6 Aug 2023 16:13:17 +0200
Subject: [PATCH] Fix incompat with immedeately fast 1.1.25

Turns out uploading empty buffers isn't the best idea I've ever had,
but it also wasn't the worst one I ever had.

Maybe results in some performance gains even, who knows.
---
 .../dev/schmarrn/lighty/event/BufferHolder.java     | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/common/src/main/java/dev/schmarrn/lighty/event/BufferHolder.java b/common/src/main/java/dev/schmarrn/lighty/event/BufferHolder.java
index f5878d9..0281a7f 100644
--- a/common/src/main/java/dev/schmarrn/lighty/event/BufferHolder.java
+++ b/common/src/main/java/dev/schmarrn/lighty/event/BufferHolder.java
@@ -43,10 +43,15 @@ void upload(BufferBuilder.RenderedBuffer buffer) {
         if (vertexBuffer != null) {
             vertexBuffer.close();
         }
-        vertexBuffer = new VertexBuffer(VertexBuffer.Usage.DYNAMIC);
-        vertexBuffer.bind();
-        vertexBuffer.upload(buffer);
-        VertexBuffer.unbind();
+        if (buffer.isEmpty()) {
+            // Don't upload
+            vertexBuffer = null;
+        } else {
+            vertexBuffer = new VertexBuffer(VertexBuffer.Usage.DYNAMIC);
+            vertexBuffer.bind();
+            vertexBuffer.upload(buffer);
+            VertexBuffer.unbind();
+        }
     }
 
     void draw(Matrix4f positionMatrix, Matrix4f projectionMatrix, ShaderInstance shader) {