Internal Server Error if request to Rollbar fails

[ktalebian]

The request to nginx fails with Internal Server Error if the request to rollbar fails. For example, set an incorrect token, and then use the reporter. You'll get a

[error] 1480#0: *69 [lua] rollbar.lua:100: invalid Rollbar response: 401 {
   "err": 1,
   "message": "invalid access token"
}, context: ngx.timer, client: x.x.x.x, server: 0.0.0.0:80

And the request fails. Failure to publish to rollbar should not cause the service to fail and the failure should be handled gracefully.

[EtienneM]

You're right. I'll not have time to work on it right away but if you can submit a PR on this one, I will happily merge it in master.

[EtienneM]

@ktalebian I will actually need more details on this issue. The Rollbar request is done in a light thread:

lua-resty-rollbar/lib/resty/rollbar.lua

Line 170 in d9bf1c0

ngx.timer.at(0, send_request, level, title, debug.traceback(), request)

Hence, if the request to Rollbar fails, nothing wrong happens to the main thread. Or am I missing about what you report?