Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't start without war file #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: don't start without war file #28

wants to merge 3 commits into from

Conversation

Frzk
Copy link
Contributor

@Frzk Frzk commented Feb 21, 2024

Fix #15

@Frzk Frzk self-assigned this Feb 21, 2024
@Frzk Frzk marked this pull request as ready for review February 21, 2024 14:47
@Frzk Frzk requested a review from Soulou February 21, 2024 14:47
leo-scalingo
leo-scalingo reviewed Feb 21, 2024
View reviewed changes
Copy link

@leo-scalingo leo-scalingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I struggle to see if this changes the behavior of the buildpack and how, can you share the acceptance tests you've done to ensure it still works as expected?

@Frzk Frzk removed the request for review from Soulou February 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-scalingo leo-scalingo leo-scalingo left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Frzk Frzk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Errors] We should not try to launch the process if no war files are found.
2 participants
@Frzk @leo-scalingo