Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output package must be prefixed with _root_ #640

Open
steinybot opened this issue Jul 30, 2024 · 0 comments · May be fixed by #642
Open

Output package must be prefixed with _root_ #640

steinybot opened this issue Jul 30, 2024 · 0 comments · May be fixed by #642

Comments

@steinybot
Copy link
Contributor

We had stOutputPackage set to web.typings. A module generated a member named web. The imports break with something like value typings is not a member of web.

All the references to the output package must be prefixed with _root_ to avoid this conflict.
steinybot added a commit to steinybot/Converter that referenced this issue Jul 31, 2024
@steinybot
Prefix output package with _root_ (ScalablyTyped#640)
43a64aa
steinybot added a commit to steinybot/Converter that referenced this issue Jul 31, 2024
@steinybot
Fix lookup (ScalablyTyped#640)
ceca32f
steinybot added a commit to steinybot/Converter that referenced this issue Jul 31, 2024
@steinybot
Update tests (ScalablyTyped#640)
86546e0
@steinybot steinybot linked a pull request Jul 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add _root_ prefix to output package steinybot/Converter
1 participant
@steinybot