Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter ignores re-exports in form of export { default as Foo } from 'foo' #603

Open
jmcclell opened this issue Feb 6, 2024 · 0 comments

Comments

@jmcclell
Copy link

jmcclell commented Feb 6, 2024

Specifically noticed while converting PixiJS.

PixiJS has a @pixi/utils package that contains the line

export { default as EventEmitter } from 'eventemitter3'

In Typescript, this means the @pixi/utils package has a module named EventEmitter and I would expect the same to be true in ScalaJS after conversion. Unfortunately, it appears to ignore it entirely.

If I were to change it to export * as EventEmitter from 'eventemitter3' I get the module as expected.

This seems like a generic issue (rather than library specific) but I still created a test under the import tests with PR #602

With this issue, importing of Pixi fails (in part) because the internal references to EventEmitter @pixi/util are not resolvable meaning none of the event-related methods / properties (e.g. on(), hitarea, etc.) are available. This makes it virtually unusable. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant