Detect preferred distance units

[sliekens]

The zone completion assistant & the tasks tracker display distances in feet by default, but they should instead detect the preferred distance unit from the user's regional settings.

In

gw2pao/GW2PAO/Modules/ZoneCompletion/ZoneCompletionModule.cs

Line 60 in 495bf52

this.userData = new ZoneCompletionUserData();

if (this.userData == null)
{
    this.userData = new ZoneCompletionUserData();

    // Add this block
    if (System.Globalization.RegionInfo.CurrentRegion.IsMetric)
    {
        this.userData.DistanceUnits = Units.Meters;
    }
}

Gotcha: the value of RegionInfo.CurrentRegion is cached for the lifetime of the application. This will bite you sooner or later. When a user changes their regional settings, CurrentRegion remains whatever it was initialized to. You can clear the cache by explicitly calling CultureInfo.ClearCachedData().

[SamHurne]

I'm marking this as a feature request, although it could be argued this is more of a "how it should just be done" request.