Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management Mode Lock #34

Open
TheJJ opened this issue May 1, 2018 · 2 comments
Open

Management Mode Lock #34

TheJJ opened this issue May 1, 2018 · 2 comments

Comments

@TheJJ
Copy link
Member

TheJJ commented May 1, 2018

Currently, when a machine is being managed, it is still used as template for started machines.

Possible improvements:

  • Perform management on a copy of the image, and overwrite the old image afterwards.
  • Perform management on a copy-on-write image like the temporary machines, but meld the cow-image back into the original image after management is done
  • Add a lock to prevent spawns of machines that use the image while it's being managed. This could be reported as "pending: waiting for management mode"

Those ideas can be combined, but each one would be an improvement already. The easiest one is the last one, I guess.

@zuntrax
Copy link
Contributor

zuntrax commented May 3, 2018

The second option might be best. We should check if it is possible to have multiple layers of copy-on-write images. Then we could just base new VM spawns on the changes fo a while and meld later, either after set time when no build is runnning or with a command that waits for all copies of the VM to terminate while delaying new VM spawns until the meld can be done.

@zuntrax
Copy link
Contributor

zuntrax commented May 3, 2018

In our own deployment, there is quite a lot of idle time, so fancy meld scheduling is not that important for us, but we should at least keep that in mind for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants