Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unintended bug on sep (Read_Labels.ipynb) #21

Open
leadawon opened this issue May 29, 2023 · 0 comments
Open

unintended bug on sep (Read_Labels.ipynb) #21

leadawon opened this issue May 29, 2023 · 0 comments

Comments

@leadawon
Copy link

Hello, I'm leadawon. I'm a beginner in nlp.

It's been a long time since you published your paper. I think it is great research!

I think I found a bug, which baffled me.

I ran Read_Labels.ipynb to create *.source. When executing

cons, sum = concat_conversion(data, labels, label_type)

within the

transform_format(prefix, label_type = '_sent_c99_label') function

, the label_type goes into sep field in concat_conversion(data, labels, sep=' |', label_type = '_sent_c99_label') function. If you think this is a problem, I would appreciate it if you could fix it. I'm always rooting for you!


my sol.
cons, sums = concat_conversation(data, labels, label_type) -> cons, sums = concat_conversation(data, labels, " | " ,label_type)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant