Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmojiOne version 2 is no longer supported or distributed #13686

Closed
wreiske opened this issue Mar 12, 2019 · 7 comments · Fixed by #13807
Closed

EmojiOne version 2 is no longer supported or distributed #13686

wreiske opened this issue Mar 12, 2019 · 7 comments · Fixed by #13807

Comments

@wreiske
Copy link
Contributor

wreiske commented Mar 12, 2019

Description:

Rocket.Chat currently uses a very outdated version of EmojiOne.
From https://github.com/emojione/emojione#emojione-version-2

EmojiOne version 2 is no longer supported or distributed.

Server Setup Information:

  • Version of Rocket.Chat Server: 70afb0e
@wreiske
Copy link
Contributor Author

wreiske commented Mar 12, 2019

Also submitted as a feature request: RocketChat/feature-requests#54

Some important information: joypixels/emojione#488 (comment)

Looks like EmojiOne is no longer open source, however, they are still providing their icons FOR FREE to services like Verizon, Slack, Discourse, Kik, etc. Maybe Rocket.Chat could be one of those?

@sampaiodiego
Copy link
Member

Maybe Rocket.Chat could be one of those?

Unfortunately not. New EmojiOne license doesn't allow it to be embedded on open source projects, so we cannot upgrade it.

We are internally discussing in either not use an emoji library at all (in this case let platform render emojis) or migrate to twemoji.. see #6740 (comment)

I would like to not have multiple discussions (in many different issues) but I would like to know your thoughts on above as well.. feel free to respond here or in the referred issue.

@wreiske
Copy link
Contributor Author

wreiske commented Mar 18, 2019

@sampaiodiego I've been in contact with EmojiOne and they would like to offer us a modified version of their free license for our use case (in Rocket.Chat).

image

@engelgabriel
Copy link
Member

Hi @wreiske thanks for doing that! Let's move forward with that offer!

@wreiske
Copy link
Contributor Author

wreiske commented Mar 18, 2019

I'll let them know we'd like to move forward. I'll work with their team and get a pull-request going here to upgrade to EmojiOne 4.5.

😀

@sampaiodiego
Copy link
Member

@wreiske please ask them about adding such on the bottom of the picker.. like in this mockup:
image

@alyssais
Copy link

Is there a copy of the full license that will apply to users of rocketchat after this upgrade? What terms does it impose on redistributors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants