Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reduce redownloading of unchanged files #59

Open
Sarkie opened this issue May 11, 2020 · 3 comments
Open

[BUG] Reduce redownloading of unchanged files #59

Sarkie opened this issue May 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@Sarkie
Copy link

Sarkie commented May 11, 2020

Describe the bug
Currently the same files are being downloading from gitub

To Reproduce
Start the software
Files will be downloaded

Expected behavior
Github api uses ETag, so you can use If-Match header on the GET request to reduce downloading

Screenshots

image

Device:

  • Device: [e.g. PSP Model or VITA]
  • FW:[e.g. Current System Firmware]
  • Daedalus Version 0.2 Nightly

Additional context
Add any other context about the problem here.

@Rinnegatamante Rinnegatamante added the enhancement New feature or request label May 11, 2020
@Sarkie
Copy link
Author

Sarkie commented May 11, 2020

@Rinnegatamante also noticed the comment regarding Content-Length missing, I think there's a bug or something with Github api - I've created a forum post.

https://github.community/t5/GitHub-API-Development-and/Content-Length-missing-randomly/m-p/57784#M4856

@Rinnegatamante
Copy link
Owner

It's not a bug, GitHub API uses chunked transmission. Chunked transmission misses Content-Length.

@e-minguez
Copy link

What about generating MD5 files? So you can check the checksum and download only a few bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants