Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve JDoc comments across file renames or path changes #98

Open
amit1rrr opened this issue Jul 21, 2021 · 0 comments
Open

Preserve JDoc comments across file renames or path changes #98

amit1rrr opened this issue Jul 21, 2021 · 0 comments

Comments

@amit1rrr
Copy link
Member

amit1rrr commented Jul 21, 2021

Problem

Currently comments made directly on the notebook (JDoc comments) are tied to the notebook name+path. If the notebook name or path is changed then it's treated as a new document. All the old conversations are not automatically migrated to this new file name / path. While these conversations are available with us, they are not really visible anywhere in the UI. Which is a poor UX.

Solution

Migrate JDoc conversations so they're available even after file rename or path changes. There are two ways to tackle this -

  1. See if we can detect file rename from Git history & automatically migrate the conversations
  2. If rename detection is not possible (e.g. user has manually deleted & recreated the same file) then offer manual migration mechanism (via UI or support email)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant