Bug Report - Emulator occasionally crashes when deleting an alt group that isn't empty

[Blazekickn]

I'm unsure when the cutoff is for when it starts crashing but I remember it happening to me often back when i was an active developer so it can't be that many conditions. Recently other users have been reporting the same issue.

[Blazekickn]

https://retroachievements.org/achievement/108175 here's an achievement i know for a fact crashes and a possible lead on the cause. If you delete alt 1, and then delete alt 1 again it crashes.

[Jamiras]

I'm unable to reproduce using 0.78.0, 0.78.3, or current master. In all cases, after successfully deleting the "second" alt 1, the achievement triggers. Tested in RALibRetro x64 and RAVBA x86.

Are you able to consistently reproduce using the specified achievement, or are you just identifying it as one where you know the problem has occurred?

[bedwardly-down]

This is TheAnxietyBuster from RA and the best way I’ve found to reproduce the issue:

1. Make around 25 or more conditions in Core
2. Make around 10 or more Alts
3. Copy those 25 conditions to each of the Alts
4. Close and Save
5. Reopen
6. Start rapidly deleting each Alt without closing
7. Seems to crash between 3 and 6 deletions most of the time for me

From my observations, it’s less likely to happen the less conditions used but doesn’t seem to be directly affected by what types of logic used. it’s happened for me with simple Delta checks before.

[bedwardly-down]

With my current test, it's not hitting today but other observations:

1. Most of the time, I have Memory Inspector open and am filtering while working with the Achievement Editor. I almost always find that I forgot something or need an extra condition to harden my achievements.
2. I use Code Notes and Bookmarks quite a bit to quickly observe address changes while testing.
3. Seemed to happen more often when I have my Browser open while using RALibRetro but predominantly when I streamed, meaning this could be tied to CPU usage somewhere, since streaming is heavily dependent on that.

My Specs:

CPU: Intel Core i7-4510 2.00 GHz
RAM: 8 GB DDR3
OS: Windows 10 64 bit Pro