From e766297adcdaf8e5d8dd996c15aed753255230fd Mon Sep 17 00:00:00 2001 From: Sven Woop Date: Wed, 13 Mar 2019 12:13:56 +0100 Subject: [PATCH] bugfix in linux RPM package generation --- common/cmake/package.cmake | 5 +++-- scripts/package_linux.sh | 13 +++++++------ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/common/cmake/package.cmake b/common/cmake/package.cmake index 0a65f78562..3c3980d5d6 100644 --- a/common/cmake/package.cmake +++ b/common/cmake/package.cmake @@ -254,7 +254,7 @@ ELSE() SET(CPACK_RPM_lib_POST_UNINSTALL_SCRIPT_FILE ${PROJECT_SOURCE_DIR}/common/cmake/rpm_ldconfig.sh) IF (EMBREE_TESTING_PACKAGE) ADD_TEST(NAME "BuildPackage" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} COMMAND ${PROJECT_SOURCE_DIR}/scripts/package_linux.sh - ${EMBREE_LIBRARY_NAME} ${EMBREE_VERSION} ${EMBREE_VERSION_MAJOR} ${EMBREE_SIGN_FILE}) + ${EMBREE_ZIP_MODE} ${EMBREE_LIBRARY_NAME} ${EMBREE_VERSION} ${EMBREE_VERSION_MAJOR} ${EMBREE_SIGN_FILE}) ENDIF() ELSE() @@ -262,7 +262,8 @@ ELSE() SET(CPACK_PACKAGE_FILE_NAME "${CPACK_PACKAGE_FILE_NAME}.x86_64.linux") SET(CPACK_MONOLITHIC_INSTALL 1) IF (EMBREE_TESTING_PACKAGE) - ADD_TEST(NAME "BuildPackage" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} COMMAND ${PROJECT_SOURCE_DIR}/scripts/package_linux.sh ${EMBREE_ZIP_MODE} ${EMBREE_VERSION} ${EMBREE_SIGN_FILE}) + ADD_TEST(NAME "BuildPackage" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} COMMAND ${PROJECT_SOURCE_DIR}/scripts/package_linux.sh + ${EMBREE_ZIP_MODE} ${EMBREE_LIBRARY_NAME} ${EMBREE_VERSION} ${EMBREE_VERSION_MAJOR} ${EMBREE_SIGN_FILE}) ENDIF() ENDIF() diff --git a/scripts/package_linux.sh b/scripts/package_linux.sh index 111200de00..b320b8d4b3 100755 --- a/scripts/package_linux.sh +++ b/scripts/package_linux.sh @@ -40,10 +40,11 @@ function check_symbols } # read embree version -EMBREE_LIBRARY_NAME=$1 -EMBREE_VERSION=$2 -EMBREE_VERSION_MAJOR=$3 -EMBREE_SIGN_FILE=$4 +EMBREE_ZIP_MODE=$1 +EMBREE_LIBRARY_NAME=$2 +EMBREE_VERSION=$3 +EMBREE_VERSION_MAJOR=$4 +EMBREE_SIGN_FILE=$5 # create package make -j 16 preinstall @@ -52,10 +53,10 @@ check_symbols lib${EMBREE_LIBRARY_NAME}.so GLIBCXX 3 4 11 check_symbols lib${EMBREE_LIBRARY_NAME}.so CXXABI 1 3 0 make -j 16 package -if [ "$1" == "OFF" ]; then +if [ "$EMBREE_ZIP_MODE" == "OFF" ]; then # sign all RPM files - if [ $# -eq 4 ]; then + if [ $# -eq 5 ]; then ${EMBREE_SIGN_FILE} embree${EMBREE_VERSION_MAJOR}-*-${EMBREE_VERSION}-*.rpm fi