Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies #5

Open
midirhee12 opened this issue Nov 14, 2021 · 3 comments
Open

Dependencies #5

midirhee12 opened this issue Nov 14, 2021 · 3 comments

Comments

@midirhee12
Copy link

Make a list of dependencies explicitly in the README.md including clang instead of just listing a line straight from the Makefile.

It's not necessary, but definitely makes the project look cleaner.

RealAlpha added a commit that referenced this issue Nov 15, 2021
Addresses issues #5 and #6
@RealAlpha
Copy link
Owner

Hi @cvoges12,

Thank you for raising this issue! This is an old project that I wrote in the space of a week when I was still learning to program in C, and I'll admit that there's quite a few parts of it that I'm not too proud of. In any case, I completely agree that a list of dependencies (and the usage of codeblocks, per your other issue in #6) is very useful!

I've added a list that I think contains all of the dependencies, but ideally I'd replace the entire current Makefile system with a proper build system such as C++ (that way it avoids the explicit dependency on C++ and is easier to set up for potential users). I'm not sure when I'll be able to get to that, so feel free to submit a PR if you're familiar with that area and would like to contribute.

@midirhee12
Copy link
Author

Alright, I'll probably be using the project if not adding some pull request here and there. Kind of wanting to tinker with Discord API in zig

@midirhee12
Copy link
Author

Honestly though, I was going to rewrite the build script using zig build, so the current Makefile is easier to read and translate over. I don't know if you'd want zig as a dependency though. It's not fully released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants