Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model viewer's model list is not always sorted #31

Closed
Phanabani opened this issue Oct 6, 2021 · 3 comments · Fixed by #94
Closed

Model viewer's model list is not always sorted #31

Phanabani opened this issue Oct 6, 2021 · 3 comments · Fixed by #94
Assignees
Labels
Bug Something isn't working UI Replanetizer UI

Comments

@Phanabani
Copy link
Contributor

For example, in RaC3 Veldin, the moby list goes is ordered 13A1, 1B78, B, D, F, 10, ....

@MilchRatchet MilchRatchet added Bug Something isn't working UI Replanetizer UI labels Oct 6, 2021
@Phanabani Phanabani self-assigned this Oct 6, 2021
@Phanabani Phanabani changed the title [Bug] Model viewer's model list is not always sorted Model viewer's model list is not always sorted Oct 8, 2021
@Phanabani
Copy link
Contributor Author

@MilchRatchet the easiest solution is to sort model lists in-place in the Level constructor, but do you think I should make separate sorted lists for UI display? I'm not sure if maintaining the original sort order (like for serializing) is important.

@MilchRatchet
Copy link
Contributor

I don't know either whether the order is relevant for serialization. I guess there is really only one way to find that out. Do you know how to test ingame? If not maybe I should probably make a tutorial for that as mentioned in #41.

@Phanabani
Copy link
Contributor Author

I might be able to figure it out, but I haven't done it before. I've never actually used RPCS3, I've just played the original trilogy on PCSX2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working UI Replanetizer UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants