Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread scheduler recommendation #910

Open
Darkhost1999 opened this issue Oct 13, 2022 · 2 comments
Open

Thread scheduler recommendation #910

Darkhost1999 opened this issue Oct 13, 2022 · 2 comments

Comments

@Darkhost1999
Copy link

Darkhost1999 commented Oct 13, 2022

If it's not recommended to use a thread scheduler unless you have 12+ threads then we probably should avoid recommending it to those who can't use the option.

https://github.com/RPCS3/rpcs3/blob/master/rpcs3/rpcs3qt/tooltips.h#L86

Screenshot

Just a thought honestly. If fewer than 12 threads don't print out the message that thread scheduler may improve performance as it may just make things worse and they'll probably disregard the tooltip thinking "The bot told me it was ok"
[The image is just an example I took from the last log I saw when thinking about this]

@13xforever
Copy link
Contributor

That's only relevant for Intel CPUs, and there's already check for that

@Asinin3
Copy link
Contributor

Asinin3 commented Jul 23, 2023

Huh? The thread scheduler is only relevant for AMD, not Intel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants