Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in timesplitting for tau = 0 cases #43

Open
shyams2 opened this issue Jan 5, 2018 · 0 comments
Open

Error in timesplitting for tau = 0 cases #43

shyams2 opened this issue Jan 5, 2018 · 0 comments

Comments

@shyams2
Copy link
Contributor

shyams2 commented Jan 5, 2018

In: f90bc8b

For tau = 0 cases, the splitting has not been carried out correctly, and is just applying f = f0 at the end of the FVM step in a single timestep.

Proposed Fix:
Considering strang splitting:

  1. Solve df/dt + A_q df/dq + A_p df/dp = 0 for dt/2
  2. Apply f = f0
  3. Solve df/dt + A_q df/dq + A_p df/dp = 0 for another dt/2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shyams2