Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of InterestPoints not necessary? #44

Open
tpietzsch opened this issue Jul 11, 2023 · 2 comments
Open

Duplication of InterestPoints not necessary? #44

tpietzsch opened this issue Jul 11, 2023 · 2 comments

Comments

@tpietzsch
Copy link
Contributor

/**
* We only read the points, no reason to duplicate, RANSAC does its own duplication
*/
@Override
public boolean requiresInterestPointDuplication() { return true; }

The javadoc comment seems to indicate that requiresInterestPointDuplication should return false.
What is wrong? The comment or the code?

@StephanPreibisch
Copy link
Member

I think I was simply afraid/conservative when I wrote the code initially since these point clouds are processed multi-threaded ... it might well be that I never came back to it

@StephanPreibisch
Copy link
Member

I think we should remove this all together maybe ... each method can simply do it if it needs it, rather than doing it on the outside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants