Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise DivisionByZeroError when calls to microdf result in division by zero #255

Closed
anth-volk opened this issue Aug 22, 2024 · 3 comments
Closed

Comments

@anth-volk
Copy link
Contributor

This is linked to PolicyEngine/policyengine-uk#928. In situations where a sim or microsim attempts to use microdf's MicroSeries class, rank method with an array of weights that equal 0, core should raise an error. This is because the rank method will attempt to divide by the sum of all values within the weights array, be unable to divide, and return an array of nan values.

@MaxGhenis
Copy link
Contributor

Should this be in microdf? Since this involves the additional weighting functionality, not just core pandas replication.

@anth-volk
Copy link
Contributor Author

Definitely

@anth-volk
Copy link
Contributor Author

Closing in light of PolicyEngine/microdf#233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants