Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suddenly Hazard Zone #67

Closed
ksjfhor opened this issue Feb 13, 2024 · 6 comments
Closed

Suddenly Hazard Zone #67

ksjfhor opened this issue Feb 13, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@ksjfhor
Copy link
Contributor

ksjfhor commented Feb 13, 2024

Hi,

I am not sure on how I am doing it. But I can replicate it.

When I was in the LightZone and then got into the Hazard Zone, then I get out of the Hazard Zone and suddenly I get the visual hint that I am in the Hazard Zone and my HP gets drained, but I am not in the Zone.
Please see the video attachment if you don't know what I mean.

hazardzone.mp4

https://www.veed.io/view/31afa1c4-a564-4a8d-922b-7f9016d32112?panel= (githubs 10 MB border is a little pain for me)

@Phazorknight
Copy link
Owner

Oh, thanks for flagging this. Will take a look.

@Phazorknight Phazorknight added the bug Something isn't working label Feb 13, 2024
@Bezoika
Copy link

Bezoika commented Feb 13, 2024

I think this is just damage from Sanity right? Once you walk into the lightzone it sets brightness level to 1 and then when you walk out it sets it to 0, after a limited amount of time you start taking damage.

@ksjfhor
Copy link
Contributor Author

ksjfhor commented Feb 14, 2024

I am not sure on how I am doing it. But I can replicate it.

Bezoika is right, when I get into the lightzone and just wait I get the same result. So it was just my stupidity, sorry to bother you.
I got confused because I was in the HazardZone just in the right time.

@ksjfhor ksjfhor closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2024
@Phazorknight Phazorknight self-assigned this Feb 15, 2024
@Phazorknight Phazorknight reopened this Feb 15, 2024
@Phazorknight
Copy link
Owner

Re-opening this so I'll look into this more:
Need to make it clear that this is happening due to the SanityComponent, as it's otherwise very confusing. Will update once I fix that.

@ksjfhor
Copy link
Contributor Author

ksjfhor commented Feb 16, 2024

I would suggest to make it visibily more clear that something other then the hazardzone is happening, like with a black overlay instead of the same (?) red of the hazardzone. Some more debug prints like "insanity now active" could also help to reduce the confusion, at least for me :)

@Phazorknight
Copy link
Owner

Should be improved with a117370:
I've added a bool flag to the player.gd to easily turn sanity off.
Also added a print that tells you if the player is losing health due to low sanity.

All of this will be improved in the future when tackling #49, but for now I consider this closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants