Bunnyhop needed ?

[ksjfhor]

Hi,
I was wondering, as I scanned the playerscript, do we need the bunnyhopping ?

Makeing it toggleable would bloat the playerscript, setting the bhop_accel to from 0.1 to 0 would make useless calculations and IMHO what Immersive Sim is using a bhop ?
I (the pro idiot) can only think of Counter Strike where bhopping is a thing, so please correct me otherwise I would try to stripe it.

[Phazorknight]

I definitely agree with you. In the spirit of "don't try to fix what's not broken" I just haven't touched it in the script yet. Would also properly test if it influences the general feel of it in any way as I currently quite like it, but feel free to have a go at it.

To keep in mind: I'm also planning on restructuring the components within the Player scene in general as currently the player.gd script is stuffed with some stuff that shouldn't be in there (see #49). It's just further down the list.

[ksjfhor]

Nice, and got you :)
I worked through the player.gd and adjusted it a bit, added more var hints for what was missing and removed a massive 11 lines and added code regions for a better readability, but did not touch any of the functions itself:
aff81d7
& here:
82eb26b
I removed the Bunnyhop. For me it feels much better and it seems that it also removed the jump acceleration that happens when you step on the ladder (or propbarly any other outstanding mesh) and jump in just the right moment (see #67, the video at 13 sec), which was a bit too much for me.

[ksjfhor]

Could be made an toggle with #115.
This is a better way than doing calculations by multiplying with 0.