Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add google's conformance test suite to find bugs #11

Open
timotheecour opened this issue Apr 2, 2018 · 2 comments
Open

add google's conformance test suite to find bugs #11

timotheecour opened this issue Apr 2, 2018 · 2 comments

Comments

@timotheecour
Copy link

just saw it on https://forum.nim-lang.org/t/3687/1#23146 as posted by @oswjk

As a side note: my library currently passes googles conformance test suite for proto3 tests that do not require JSON input/output. A lot of silly mistakes were fixed while running test suite. It's very nice of google to provide it.

looks like should be easy to add, as done here: https://github.com/oswjk/protobuf-nim/blob/master/tests/conformance/

@PMunch
Copy link
Owner

PMunch commented Apr 3, 2018

Currently this implementation supports neither maps nor options, so that would fail at the parsing step. I am planning to add that in the near future though, but until then this will have to wait.

@oskaritimperi
Copy link

If you have any questions about the conformance test stuff, just ask. It was very nice to get it running to see how well my creation fares. :-)

When you start implementing it for your library, you can copy-paste as much code as you want from my version (as if there was a lot of it ;-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants