Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Auto setup, when IsUninitialized, response http status code 409 #16833

Open
infofromca opened this issue Oct 4, 2024 · 2 comments · May be fixed by #16834
Open

In Auto setup, when IsUninitialized, response http status code 409 #16833

infofromca opened this issue Oct 4, 2024 · 2 comments · May be fixed by #16834
Labels
enhancement
Milestone
2.x

Comments

@infofromca
Copy link
Contributor

Describe the bug

In Auto setup, when IsUninitialized, response http status code 409 to let user know the error clearly.

Orchard Core version

2.0
Add the version of the Orchard Core NuGet packages you use, or the commit hash if you can reproduce this with the source code.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'AutoSetup'
    when IsUninitialized
  2. See error
  3. httpContext.Response.Redirect(pathBase); will make the users to think the site got success.

Expected behavior

A clear and concise description of what you expected to happen.
return status code 409

Logs and screenshots

If applicable, add log files, browser console logs, and screenshots (or screen recording videos) to help explain your problem.
@infofromca infofromca linked a pull request Oct 4, 2024 that will close this issue
Open
@sebastienros sebastienros added this to the 2.x milestone Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@gvkries
Copy link
Contributor

gvkries commented Oct 10, 2024

The correct status code would be 503.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.x
Development

Successfully merging a pull request may close this issue.

In Auto setup, when IsUninitialized, response http status code 503 infofromca/OrchardCore
3 participants
@infofromca @sebastienros @gvkries