Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seo module crashing whole GraphQL schema #16140

Closed
tropcicstefan opened this issue May 22, 2024 · 2 comments · Fixed by #16143
Closed

Seo module crashing whole GraphQL schema #16140

tropcicstefan opened this issue May 22, 2024 · 2 comments · Fixed by #16143
Labels
Milestone

Comments

@tropcicstefan
Copy link
Contributor

Describe the bug

When done activating OrchardCore.Seo feature whole GraphQL schema will crash and be unusable. Because of way MediaField in SeoMetaQueryObjectType is resolved

To Reproduce

Steps to reproduce the behavior:

  1. site with headless recipe
  2. go to graphi, everything works
  3. activate seo feature
  4. go to graphi
  5. exception
@gvkries
Copy link
Contributor

gvkries commented May 23, 2024

The problem is that GraphQL types are registered as scoped in DI and those cannot be resolved while the schema is build as a singleton. I think the fix is to make them transient instead, but I'm not fully sure about the implications.

@gvkries
Copy link
Contributor

gvkries commented May 30, 2024

Note that this also caused CustomUserSettings types with a media field to break the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants