Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct docs regarding flash attention #1777

Open
BBC-Esq opened this issue Sep 10, 2024 · 3 comments
Open

correct docs regarding flash attention #1777

BBC-Esq opened this issue Sep 10, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@BBC-Esq
Copy link

BBC-Esq commented Sep 10, 2024

Flash Attention is still listed in the documentation:

https://opennmt.net/CTranslate2/python/ctranslate2.Generator.html

I'd recommend keeping it since you do not have a history of documentation for different versions...and then just add a bullet point mentioning that it's only available for version 4.3.1 or 4.3 or whatever...

Not sure if it's mentioned elsewhere in the documentation, didn't check everywhere...

@minhthuc2502
Copy link
Collaborator

Thank you for your feedback. I will update the doc and version handler ASAP.

@minhthuc2502 minhthuc2502 added the documentation Improvements or additions to documentation label Sep 12, 2024
@winstxnhdw
Copy link

@BBC-Esq have you seen any benefits to using Flash Attention?

@BBC-Esq
Copy link
Author

BBC-Esq commented Sep 13, 2024

I re-ran some limited testing, including some very large contexts, and did not see much if any improvement - either in tokens/s or VRAM usage. However, I haven't been able to fully test it yet. My previous tests, for whatever reason, indicated a discernable improvement when running models that have a certain architecture (I believe it was Mistral) but not Llama-based for some reason. I'd have to revisit my prior benchmarks and update them to be certain and will post when I get the time to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants