Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP-Redirect signatures are ignored unless 'redirect.sign' is set #247

Open
relaxnow opened this issue Jan 15, 2016 · 2 comments
Open

HTTP-Redirect signatures are ignored unless 'redirect.sign' is set #247

relaxnow opened this issue Jan 15, 2016 · 2 comments

Comments

@relaxnow
Copy link
Contributor

At the very least this should trigger a log warning.

@relaxnow relaxnow added the bug label Jan 15, 2016
@thijskh
Copy link
Member

thijskh commented Sep 8, 2016

Should it? If we don't require a signature, but someone sends a message with one, why is it a problem to just continue and act if there was none?

@relaxnow relaxnow added enhancement and removed bug labels Sep 8, 2016
@relaxnow
Copy link
Contributor Author

relaxnow commented Sep 8, 2016

This issue was created in response to an issue where an SP was misconfigured but we didn't notice until we connected the SP to a different IdP but were puzzling over why suddenly the signature was broken.

I agree that OpenConext is not required to validate the signature (changed this to enhancement).
However if an SP sends a signature anyway this could be indicative of a misconfigured SP or worse an SP that expects request verification because it wants us to redirect to a different ACS or it wants to be used as an SP proxy (like Stepup Gateway) but we simply ignore it.

Somewhere there is a difference between what we expect the SP to send and what it actually sends. While I agree that we shouldn't break on it, ideally you'd inform the SP so it doesn't expect us to do something we don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants