Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hamburger buttons to update or delete an attack pattern within an incident doesn't work and redirect to the attack pattern page. #8330

Open
sancievanneaud opened this issue Sep 12, 2024 · 5 comments · May be fixed by #8653
Open

Hamburger buttons to update or delete an attack pattern within an incident doesn't work and redirect to the attack pattern page. #8330

sancievanneaud opened this issue Sep 12, 2024 · 5 comments · May be fixed by #8653
Assignees
@CelineSebe
Labels
bug use for describing something not working as expected ui for scope limited to UI change
Milestone
Bugs backlog

Comments

@sancievanneaud
Copy link

sancievanneaud commented Sep 12, 2024 •
edited by Lhorus6
Loading

Description

When clicking on the hamburger buttons to update or delete an attack pattern within an incident, the modification drop down menu appears just 2 sec and then redirect to the attack pattern page.

Environment

  1. OpenCTI version: 6.2.18

Reproducible Steps

  1. Go to an incident page
  2. Knowledge
  3. In Techniques, select Attack Pattern
  4. Select Kill chain vue
  5. On an attack pattern, click on the hamburger buttons at the right side
  6. The modification window appears just 2 sec
  7. The click redirect to the attack pattern page.

Expected Output

Display the modification drop down menu to click on the update or delete button.

Actual Output

The modification drop down menu appears just 2 sec and the click redirect to the attack pattern page.
@sancievanneaud sancievanneaud added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Sep 12, 2024
@Lhorus6 Lhorus6 changed the title Icon/3 buttons to update or delete an attack pattern within an incident doesn't work and redirect to the attack pattern page. Hamburger buttons to update or delete an attack pattern within an incident doesn't work and redirect to the attack pattern page. Sep 12, 2024
@romain-filigran
Copy link
Member

romain-filigran commented Sep 13, 2024 •
edited
Loading

Reproduced on any views with kill chain view

@romain-filigran romain-filigran added ui for scope limited to UI change and removed needs triage use to identify issue needing triage from Filigran Product team labels Sep 13, 2024
@CelineSebe CelineSebe self-assigned this Sep 17, 2024
@nino-filigran nino-filigran added this to the Bugs backlog milestone Sep 18, 2024
CelineSebe added a commit that referenced this issue Oct 14, 2024
@CelineSebe
[frontend]fix(#8330)
19e98fe
@CelineSebe CelineSebe linked a pull request Oct 14, 2024 that will close this issue
Draft
5 tasks
@CelineSebe CelineSebe linked a pull request Oct 14, 2024 that will close this issue
[frontend] Fix burger buttons to update or delete an attack pattern within an incident(#8330) #8653
Draft
5 tasks
CelineSebe added a commit that referenced this issue Oct 14, 2024
@CelineSebe
[frontend]fix UI(#8330)
63f5274
CelineSebe added a commit that referenced this issue Oct 21, 2024
@CelineSebe
[frontend]fix(#8330)
1a5138f
CelineSebe added a commit that referenced this issue Oct 21, 2024
@CelineSebe
[frontend]fix UI(#8330)
38951fa
@CelineSebe
Copy link
Member

CelineSebe commented Oct 21, 2024 •
edited
Loading

@nino-filigran @romain-filigran I solved the issue with the redirection, but when I try to update, it's not possible because we have a component, relationshipEditionComponent, which doesn't retrieve the relationship here.
Based on my investigation, what I understand is that the relationship we're trying to open, update, or delete is at play here. But, we might only have access to the entity.

My question is:
Do we want to update the relationship or the entity in this context?

@CelineSebe CelineSebe added the needs more info Intel needed about the use case label Oct 21, 2024
@nino-filigran
Copy link

For me, we expect to edit the relation. Because if you're redirected to the attack pattern's page, then you will need to find manually the entity you were in to potentially update or delete the relation, which is annoying. Is that possible @CelineSebe ?

@CelineSebe
Copy link
Member

CelineSebe commented Oct 21, 2024 •
edited
Loading

For me, we expect to edit the relation. Because if you're redirected to the attack pattern's page, then you will need to find manually the entity you were in to potentially update or delete the relation, which is annoying. Is that possible @CelineSebe ?

@nino-filigran When you click on the line, you are redirected to the entity that you can modify, delete, etc. With the 3 points of the line (kill chain view), you can completely delete the entity with the previous code, not the relationship.

@CelineSebe CelineSebe removed the needs more info Intel needed about the use case label Oct 21, 2024
@nino-filigran
Copy link

Yes. & the goal is that if you click on the 3 dots, we should access the relationship, not the entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CelineSebe CelineSebe

Labels
bug use for describing something not working as expected ui for scope limited to UI change
Projects
None yet
Milestone
Bugs backlog
4 participants
@CelineSebe @nino-filigran @sancievanneaud @romain-filigran