fix: fix ci check format failed #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough本次更改涉及多个文件的格式化调整，主要集中在方法声明和构造函数的语法上。具体而言，多个类的方法实现中去掉了大括号前的空格，构造函数的初始化列表末尾的分号被替换为大括号。工作流配置文件也进行了更新，将格式检查步骤的命令从 Changes
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (12)
✅ Files skipped from review due to trivial changes (9)
🔇 Additional comments (6).github/workflows/pikiwidb.yml (1)
将格式检查命令更改为 让我们验证一下这个 make 目标是否正确配置： ✅ Verification successful格式检查配置已正确设置 根据代码库分析，格式检查配置已正确设置：
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# 描述：验证 check-format 目标在 CMake 构建系统中是否正确配置
# 测试：检查 CMakeLists.txt 文件中是否定义了 check-format 目标
rg -l "add_custom_target.*check-format"
# 测试：检查是否有相关的格式化配置文件
fd -t f ".clang-format$"
Length of output: 68 Script: #!/bin/bash
# 检查 Makefile 中是否定义了 check-format 目标
fd -t f "Makefile$|\.mk$" --exec cat {}
# 检查是否有其他格式化相关的文件
fd -t f "format|fmt|style" --exec echo "=== {} ===" \; --exec cat {}
Length of output: 53807 Script: #!/bin/bash
# 检查 CMakeLists.txt 中的格式化相关配置
fd -t f "CMakeLists.txt$" --exec cat {}
# 检查是否有 .clang-format 配置文件
find . -maxdepth 1 -name ".clang-format" -type f -exec cat {} \;
# 检查 Makefile 中的格式化目标
find . -maxdepth 1 -name "Makefile" -type f -exec cat {} \;
Length of output: 24663 src/net/event_server.h (2)
代码格式调整将
与 src/net/thread_manager.h (3)
格式调整将
将
函数签名的格式调整合理，包括：
这些改动使代码格式更加规范，符合项目的代码风格要求。 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
chejinge
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复因clang format版本不一致导致的format code不同的问题
Summary by CodeRabbit
Bug Fixes
Chores