Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install all include files #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KrisThielemans
Copy link

Fixes #51

However, I'm not sure if this is a good idea. The names of these include files could potentially overlap with names from other packages. It would be far better to put include files in a subdir e.g. nipet/scanner_0.h, such that such conflicts can be avoided.

Up to you if you want to merge this. I'm stuck anyway (#52)

@casperdcl
Copy link
Member

hmm I think headers in niftypet/nipet/{lm,prj,sct}/src/*.h need to be moved to niftypet/nipet/include/ if they need to be exposed publicly.

@pjmark wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include files missing from PyPy installation
2 participants