Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of thrust::tuple in RAPIDS with cuda::std::tuple #1412

Open
Tracked by #1382
miscco opened this issue Feb 20, 2024 · 2 comments
Open
Tracked by #1382

Replace usages of thrust::tuple in RAPIDS with cuda::std::tuple #1412

miscco opened this issue Feb 20, 2024 · 2 comments

Comments

@miscco
Copy link
Collaborator

miscco commented Feb 20, 2024

There are a lot of usages of thrust::tuple inside of rapids we should replace all of those with cuda::std::tuple instead

https://github.com/search?q=org%3Arapidsai+%3Cthrust%2Ftuple.h%3E&type=code

@alliepiper alliepiper changed the title Replace usages of thrust::tuple with cuda::std::tuple Replace usages of thrust::tuple in RAPIDS with cuda::std::tuple Feb 20, 2024
@jrhemstad
Copy link
Collaborator

For clarity, we only need to remove usages that look like this:

void public_rapids_api(thrust::tuple<...>)

Things like this are fine:

void public_rapids_api( device_span<thrust::tuple<...>>)

@bdice
Copy link
Contributor

bdice commented Feb 28, 2024

This work should also include thrust::pair / cuda::std::pair, in my understanding.

Things like this are fine:

void public_rapids_api( device_span<thrust::tuple<...>>)

@jrhemstad Can you explain why this doesn't require changes? Is that only true for span-like types or also for owning containers like vector? Even if not strictly necessary, I would like to migrate everything to cuda::std types if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants