Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water Heater Installation Location tsv #1094

Closed
jmaguire1 opened this issue Jun 28, 2023 · 2 comments · Fixed by #1125
Closed

Water Heater Installation Location tsv #1094

jmaguire1 opened this issue Jun 28, 2023 · 2 comments · Fixed by #1125
Assignees

Comments

@jmaguire1
Copy link
Contributor

jmaguire1 commented Jun 28, 2023

RECS2020 now has data on water heater installation location by state. Right now we use the following algorithm to default WH location:

  • If in IECC Climate Zone 1-3: Install in a garage (if available), then living space.
  • In all other Climate Zones: Install in basement (conditioned or unconditioned, if available), then living space.

def self.get_default_location(hpxml, climate_zone_iecc)
iecc_zone = (climate_zone_iecc.nil? ? nil : climate_zone_iecc.zone)
if ['1A', '1B', '1C', '2A', '2B', '2C', '3B', '3C'].include? iecc_zone
location_hierarchy = [HPXML::LocationGarage,
HPXML::LocationLivingSpace]
elsif ['3A', '4A', '4B', '4C', '5A', '5B', '5C', '6A', '6B', '6C', '7', '8'].include? iecc_zone
location_hierarchy = [HPXML::LocationBasementConditioned,
HPXML::LocationBasementUnconditioned,
HPXML::LocationLivingSpace]
elsif iecc_zone.nil?
location_hierarchy = [HPXML::LocationBasementConditioned,
HPXML::LocationBasementUnconditioned,
HPXML::LocationLivingSpace]
)

This will be an improvement particularly relevant for HPWHs. @lixiliu has a project that wants to explore 120 V HPWHs (which I'll be adding to OS-HPXML over the next few months), so this will be especially helpful for that project.

Timing wise, I'll probably get started on this around end of July, this is just an early notice.

@jmaguire1 jmaguire1 self-assigned this Jun 28, 2023
@shorowit
Copy link
Contributor

@jmaguire1 I'd be interested to know if the data suggests changes to the OS-HPXML defaults for any climate zones too.

@jmaguire1
Copy link
Contributor Author

@shorowit: Sure! This has long been something I've wanted to update but didn't realize we had data for until recently. Once I've parsed out the RECS2020 data I'll send you a note with some recommendations.

@lixiliu lixiliu mentioned this issue Aug 24, 2023
7 tasks
@shorowit shorowit linked a pull request Sep 14, 2023 that will close this issue
7 tasks
@lixiliu lixiliu closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants