The gefs prep_emissions task has a dependency dictionary, but it's never used

[DavidHuber-NOAA]

What is wrong?

The code

global-workflow/workflow/rocoto/gefs_tasks.py

Lines 47 to 62 in 7088a91

	deps = []
	dep_dict = {'type': 'task', 'name': f'stage_ic'}
	deps.append(rocoto.add_dependency(dep_dict))
	dependencies = rocoto.create_dependency(dep=deps)
	resources = self.get_resource('prep_emissions')
	task_name = 'prep_emissions'
	task_dict = {'task_name': task_name,
	'resources': resources,
	'envars': self.envars,
	'cycledef': 'gefs',
	'command': f'{self.HOMEgfs}/jobs/rocoto/prep_emissions.sh',
	'job_name': f'{self.pslot}_{task_name}_@H',
	'log': f'{self.rotdir}/logs/@Y@m@d@H/{task_name}.log',
	'maxtries': '&MAXTRIES;'
	}

builds a dependency dictionary for prep_emissions based on stage_ic, but does not define a dependency in the XML.

What should have happened?

It is not clear if this dependency should exist or not. If it is required, then the dependency should be added to prevent unexpected behavior. Otherwise, the dependency dictionary should be removed.

What machines are impacted?

All or N/A

What global-workflow hash are you using?

7088a91

Steps to reproduce

Run create_experiment.py -y ci/cases/C48_S2SWA_gefs.yaml and check the resulting XML.

Additional information

No response

Do you have a proposed solution?

Either delete the dependency dictionary or add it to the XML.