-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit conversion bug in ccpp_prebuild.py: variables that are slices of a n+1 dimensional array have wrong allocation #598
Closed
climbfuji opened this issue
Oct 9, 2024
· 1 comment
· Fixed by #600 · May be fixed by NOAA-EMC/fv3atm#878
Closed
Unit conversion bug in ccpp_prebuild.py: variables that are slices of a n+1 dimensional array have wrong allocation #598
climbfuji opened this issue
Oct 9, 2024
· 1 comment
· Fixed by #600 · May be fixed by NOAA-EMC/fv3atm#878
Labels
Comments
climbfuji
changed the title
Oh. That's a different issue though than what is described above (https://github.com/NCAR/ccpp-framework/issues/594#issue-2557281057). It's still a bad bug but should probably have its own issue.
Unit conversion bug in ccpp_prebuild.py: variables that are slices of a n+1 dimensional array have wrong allocation
Oct 9, 2024
I have a simple reproducer that I am going to commit to the repo as a new test, hopefully together with a fix!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From #594 (comment)
@climbfuji @peverwhee I can confirm that this is an issue with Prebuild.
Here are snippets from a cap where I am calling two radiation schemes, first RRTMG w/o unit conversions, and then a second ML based radiation that requires unit conversions. Look at cld_ref_Lliq and tmpvar_1
Local declaration for unit-transfroms (2D)
Input to scheme A, no unit conversion:
Input to scheme B, unit conversion (wrong allocation)
The text was updated successfully, but these errors were encountered: