Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip 5/5.1 #1063

Open
AlexanderRichert-NOAA opened this issue Oct 8, 2024 · 4 comments · May be fixed by #1062
Open

ip 5/5.1 #1063

AlexanderRichert-NOAA opened this issue Oct 8, 2024 · 4 comments · May be fixed by #1062
Labels
Clean up enhancement New feature or request

Comments

@AlexanderRichert-NOAA
Copy link
Contributor

Just as a headsup, the sp library is deprecated and its functionality is now under ip 5.0 (present in spack-stack-1.8.0; #983). Moving to ip 5.0 should be fairly straightforward, and involves removing/replacing find_package(sp) and target_link_libraries(sp:sp_*). For ip 5.1, which will hopefully be in spack-stack-1.9.0, the sp functionality is in a module and therefore must be accessed through use sp_mod.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added enhancement New feature or request Clean up labels Oct 8, 2024
@FernandoAndrade-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA would you like to introduce your proposed updates to my #1062, or would you prefer a separate PR? This seems like a related update to link to the PR.

@AlexanderRichert-NOAA
Copy link
Contributor Author

Sure, I'll try adding it to #1062.

@FernandoAndrade-NOAA
Copy link
Collaborator

I've added you as fork collaborator, so there should hopefully be no issues making updates to the PR branch.

@FernandoAndrade-NOAA FernandoAndrade-NOAA linked a pull request Oct 9, 2024 that will close this issue
@AlexanderRichert-NOAA
Copy link
Contributor Author

Sounds good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean up enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants