Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landuse_transition_matrix is uninitialized for non-land use run modes #1230

Closed
2 tasks
glemieux opened this issue Jul 23, 2024 · 1 comment · Fixed by #1231
Closed
2 tasks

landuse_transition_matrix is uninitialized for non-land use run modes #1230

glemieux opened this issue Jul 23, 2024 · 1 comment · Fixed by #1231

Comments

@glemieux
Copy link
Contributor

glemieux commented Jul 23, 2024

Original issue discovered in ESCOMP/CTSM#2656, which was overlooked due to ESCOMP/CTSM#2657. I think we just need to initialize this to zero in EDInitMod via zero_site (as we do with site_in%disturbance_rates).

Note that this appears while using the gnu compiler on derecho. Other compilers on derecho initialize to zero.

  • check if this shows up with gnu on derecho without debug
  • check if this shows up on perlmutter with gnu
@glemieux glemieux changed the title landuse_transition_matrix is uninitialized for satelite phenology tests landuse_transition_matrix is uninitialized for non-land use run modes Jul 23, 2024
@glemieux
Copy link
Contributor Author

glemieux commented Jul 23, 2024

Noting this here for posterity: the garbage output is also showing up with land use mode on for the first time step (written during initialization, but prior to fates dynamics_driv call). That said, the matrix is appropriately updated on the second step (i.e. first dynamics update). So this technically affects all run modes, not just satellite phenology, but only during the first time step. Since we avoid disturbance_rates in sp mode, this shows up as unitialized for every time step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant