Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schools should share more code #177

Open
thatoddmailbox opened this issue Sep 8, 2021 · 0 comments
Open

Schools should share more code #177

thatoddmailbox opened this issue Sep 8, 2021 · 0 comments
Labels
needs api server Needs API server changes

Comments

@thatoddmailbox
Copy link
Member

thatoddmailbox commented Sep 8, 2021

There's a lot of code for the schools that is reimplemented several times and could probably be merged:

  • Keeping track of the import status
    • Showing the "you need to update" notification when we set that flag
  • Enrollment components
    • This is tricky because the schools are somewhat different here, but not really as different as I thought they'd been when first building everything.
  • Announcements/holidays
    • Obviously the actual holidays are different, but the code for them is basically the same.
  • I think every school has its own implementation of looping over every date in the range requested in GetView. I'm not really sure how to best simplify this though.
  • Parsing username and password in Enroll
    • This is minor, but there's definitely some boilerplate with parsing the username and password from the params map. I don't really think there's a great way to simplify this without removing the flexibility of the params (which is useful for schools that need a bit more logic than just username/password).
@thatoddmailbox thatoddmailbox added the needs api server Needs API server changes label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs api server Needs API server changes
Projects
None yet
Development

No branches or pull requests

1 participant