-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating from DTypePointer
to UnsafePointer
#92
Comments
@mmenendezg Has it been confirmed that it will make it to the main branch in the next Mojo update? They have changed direction regarding this several times. |
I've only seen the changelog on the nightly branch, but I guess we should wait until the changes are applied to the main branch. |
@MadAlex1997 It seems like |
@mmenendezg They have reverted things of that scale in the main updates before. Regardless we need them to decide what the API for SIMD data loading is, as there is still a debate between We can do it correctly once instead of chasing 5 or 10 changes, each of which might take 30 minutes to multiple hours. This is why, in addition to version stability and access (ie magic being functional and easy to add packages to), until Mojo is much more stable we don't plan on making a build based on Mojo features between main releases. We have discussed this on the Numojo Discord you are welcome to join the conversation. |
The PR #108 migrates NuMojo from Mojo 24.4 to 24.5 and uses |
The Mojo team has confirmed in the nightly changelog that they will deprecate the
DTypePointer
, and they suggest migrating toUnsafePointer
.They have also changed the methods of the
UnsafePointer
.This will require to change the way we initialize the pointers for the
data
of theNDArray
s.I can help on the migration using
Max Nightly
for theNDArray
struct.The text was updated successfully, but these errors were encountered: