Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freecam keybind registers when using the gamemode switcher #249

Closed
1 of 3 tasks
JelCraft opened this issue Sep 23, 2024 · 2 comments
Closed
1 of 3 tasks

Freecam keybind registers when using the gamemode switcher #249

JelCraft opened this issue Sep 23, 2024 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@JelCraft
Copy link

Description of the issue

When pressing the keybind combination to toggle the gamemode switcher (F3+F4), this also toggles freecam if the default Freecam keybind (F4) is enabled in the config. This only happens when the player has permission to toggle gamemodes.

Expected behavior

When pressing F3+F4 Freecam should not activate. Even if the default Freecam keybind is F4.

Steps to reproduce

  1. Open a singleplayer world or join a server
  2. Press F3+F4 (with /gamemode permissions)
  3. The gamemode switcher pops up as expected, but Freecam also activates

Log output

No response

Crash report

No response

How prevalent is the issue?

Every time the gamemode switcher is used

Freecam version

1.3.0

Are you using "Modrinth Edition"?

Yes

Minecraft version

1.21.0

Modding platform

  • Fabric
  • Neoforge
  • Forge
@JelCraft JelCraft added bug Something isn't working unverified A new issue that we haven't reproduced. labels Sep 23, 2024
@MattSturgeon
Copy link
Member

Hm, it's been a while since I looked at this but I remember specifically having this case in mind when I last worked on the keybind implementation.

Thanks for the report. I'll try and find time to investigate if nobody beats me to it.

@MattSturgeon
Copy link
Member

Ah, I remember now.

This is a duplicate of #175.

TL;DR:

  • If you release F4 after releasing F3, then freecam's keybind is triggered.
  • If you release F4 while still holding F3, you should get the intended behaviour.

@MattSturgeon MattSturgeon closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
@MattSturgeon MattSturgeon added duplicate This issue or pull request already exists and removed unverified A new issue that we haven't reproduced. labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants