Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments and annotations supports w/o breaking signature #209

Open
Larsene opened this issue Jan 31, 2023 · 1 comment
Open

Comments and annotations supports w/o breaking signature #209

Larsene opened this issue Jan 31, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Larsene
Copy link

Larsene commented Jan 31, 2023

Hi, first, thanks for all your work on pyHanko, who is really usefull.

Yeah, i know that you've written "The most lenient document modification policy (i.e. addition of comments and annotations) is not supported. "

I'm just asking if there is any chance that pyHanko will support it or perhaps do you know how to do that with another python package ?

Many thanks

@MatthiasValvekens
Copy link
Owner

MatthiasValvekens commented Jan 31, 2023

I'm just asking if there is any chance that pyHanko will support it [...]

Sure, eventually I might get around to implementing it. The problem is, though, that these DocMDP policies are defined very vaguely, and "allow annotations" is a much broader scope than "allow form filling/signing". So the main effort bottleneck is in painstakingly testing interoperability with popular viewers.

Orthogonal to the implementation question, the "allow annotations" level is also pretty objectively bad in terms of security UX. That's the other main reason why I never made it a priority.

[...] or perhaps do you know how to do that with another python package ?

No, and I'll go even further: I'm not aware of any other open source project that has made a serious attempt at implementing DocMDP in general---but if you do find any, please let me know!


EDIT: I assumed that you were asking about validation support. Producing certification signatures with DocMDP level 3 is actually possible already.

@MatthiasValvekens MatthiasValvekens added the enhancement New feature or request label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants