Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to using sha256 for IdDeterministic #3

Open
CMCDragonkai opened this issue Oct 13, 2021 · 0 comments
Open

Change to using sha256 for IdDeterministic #3

CMCDragonkai opened this issue Oct 13, 2021 · 0 comments
Labels
development Standard development

Comments

@CMCDragonkai
Copy link
Member

Specification

The current IdDeterministic uses uuidv5 which uses sha1. The sha1 is now broken and not cryptographically secure. Our usage of IdDeterministic is meant to be cryptographically secure so it would be best to change to sha256 and just truncate to 128 bits. We can keep the uuidv5 spec though as it's indistinguishable from a uuidv5.

Tasks

  1. ...
  2. ...
  3. ...
@CMCDragonkai CMCDragonkai added the development Standard development label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

No branches or pull requests

1 participant