Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the kwarg timeout to Connect to Browser #3668

Open
mardukbp opened this issue Jun 24, 2024 · 3 comments
Open

Add the kwarg timeout to Connect to Browser #3668

mardukbp opened this issue Jun 24, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request priority: high
Milestone

Comments

@mardukbp
Copy link

mardukbp commented Jun 24, 2024

Is your feature request related to a problem? Please describe.
When calling New Browser the kwarg "timeout" determines the time that Browser Library waits for the browser to start. The standard value is 30s. When connecting to a running browser with Connect to Browser there is no way to change the time that Browser Library waits for the connection to be established. Playwright does support this parameter.

Describe the solution you'd like
Connect to Browser has a kwarg "timeout".

Describe alternatives you've considered
N/A

Additional context
Add any other context or screenshots about the feature request here.

@aaltat
Copy link
Member

aaltat commented Jun 25, 2024

Sounds reasonable

@allcontributors please add @mardukbp for ideas.

Copy link
Contributor

@aaltat

@mardukbp already contributed before to ideas

@aaltat aaltat added enhancement New feature or request priority: high labels Jun 25, 2024
@mardukbp
Copy link
Author

mardukbp commented Sep 4, 2024

@aaltat This enhancement is not urgent. Feel free to lower its priority.

@Snooz82 Snooz82 self-assigned this Oct 6, 2024
@Snooz82 Snooz82 modified the milestones: v18.9.0, v18.10.0 Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high
Projects
None yet
Development

No branches or pull requests

3 participants