Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version to changelog even if the version is already published #1539

Open
joshka opened this issue Jul 5, 2024 · 1 comment
Open

add version to changelog even if the version is already published #1539

joshka opened this issue Jul 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@joshka
Copy link

joshka commented Jul 5, 2024

Bug description

I'm using Release-plz automation in https://github.com/joshka/bevy_ratatui, and released 0.5.3 via the normal workflow of push a PR, get a release PR, push that. I realized that this probably should have been 0.6.0 due to a core dependency update, So I slapped a quick cargo.toml bump PR and pushed that. Release-plz automatically released 0.6.0 without any changelog updates.

What did I do wrong here?

Expected: bumping cargo toml and pushing generates a release PR for that version
Actual: release-plz publishes any release version automatically without a PR

joshka/bevy_ratatui@9d26164

  • Would you like to work on a fix? [y/n] maybe
@joshka joshka added the bug Something isn't working label Jul 5, 2024
@MarcoIeni
Copy link
Owner

You did nothing wrong. Release-plz doesn't do this at the moment.

That's because release-plz sees your new version as already published so it thinks there's nothing to do.

Pr welcome 👍

@MarcoIeni MarcoIeni added enhancement New feature or request and removed bug Something isn't working labels Jul 14, 2024
@MarcoIeni MarcoIeni changed the title Bumping version, expected Release PR add version to changelog even if the version is already published Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants