Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New guesser interface broke behaviour downstream #4748

Open
IAlibay opened this issue Oct 20, 2024 · 7 comments
Open

New guesser interface broke behaviour downstream #4748

IAlibay opened this issue Oct 20, 2024 · 7 comments

Comments

@IAlibay
Copy link
Member

IAlibay commented Oct 20, 2024

Several mdakits' CI broke overnight with the following error: ValueError: there is no reference attributes in this universeto guess types froma

This means that the new guessers interface did a breaking change that we aren't aware of.

This will need to be fixed before the 2.8 release.

@lilyminium
Copy link
Member

I'm just out but can look at this in an hour or so!

@IAlibay
Copy link
Member Author

IAlibay commented Oct 20, 2024

Prolif also fails because we removed the guessers interface: ModuleNotFoundError: No module named 'MDAnalysis.topology.guessers'

@IAlibay
Copy link
Member Author

IAlibay commented Oct 20, 2024

Similarly pytim fails because it attempts to call guess_types but it no longer exists: https://github.com/MDAnalysis/MDAKits/actions/runs/11422930196/job/31781508635#step:10:33

@IAlibay
Copy link
Member Author

IAlibay commented Oct 20, 2024

cc @Marcello-Sega - this is where we're tracking the breaking changes from the guessers update: MDAnalysis/MDAKits#217

@IAlibay
Copy link
Member Author

IAlibay commented Oct 20, 2024

I have raised #4749, #4750, and #4751 as issues that need fixing before the release.

@orbeckst
Copy link
Member

@lilyminium and @IAlibay I put both your names on this omnibus issue as the two people with best insight into what needs to be done.

You also already created PRs addressing all the sub-issues (thank you!) so I assigned the issues to the PR authors so that it's clear that we are actively working on the problems.

Please ask for help where needed.

@orbeckst orbeckst mentioned this issue Oct 21, 2024
5 tasks
@orbeckst
Copy link
Member

I created the post #4758 as an official note.

@orbeckst orbeckst added this to the Release 2.8.0 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants